Address code review feedback

microsoft · Oct 14, 2024 · c3fee6b · c3fee6b
1 parent c5fc450
commit c3fee6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dotnet/src/SemanticKernel.Core/Functions/KernelFunctionFromMethod.cs b/dotnet/src/SemanticKernel.Core/Functions/KernelFunctionFromMethod.cs
@@ -118,8 +118,7 @@ public static KernelFunctionMetadata CreateMetadata(
         IEnumerable<KernelParameterMetadata>? parameters = null,
         KernelReturnParameterMetadata? returnParameter = null,
         ILoggerFactory? loggerFactory = null)
-    {
-        return CreateMetadata(
+        => CreateMetadata(
             method,
             new KernelFunctionFromMethodOptions
             {
@@ -129,14 +128,14 @@ public static KernelFunctionMetadata CreateMetadata(
                 ReturnParameter = returnParameter,
                 LoggerFactory = loggerFactory
             });
-    }
 
     /// <summary>
     /// Creates a <see cref="KernelFunctionMetadata"/> instance for a method, specified via an <see cref="MethodInfo"/> instance.
     /// </summary>
     /// <param name="method">The method to be represented via the created <see cref="KernelFunction"/>.</param>
     /// <param name="options">Optional function creation options.</param>
     /// <returns>The created <see cref="KernelFunction"/> wrapper for <paramref name="method"/>.</returns>
+    [Experimental("SKEXP0001")]
     public static KernelFunctionMetadata CreateMetadata(
         MethodInfo method,
         KernelFunctionFromMethodOptions? options = default)

diff --git a/dotnet/src/SemanticKernel.UnitTests/Functions/KernelFunctionMetadataFactoryTests.cs b/dotnet/src/SemanticKernel.UnitTests/Functions/KernelFunctionMetadataFactoryTests.cs
@@ -7,6 +7,7 @@
 using Xunit;
 
 namespace SemanticKernel.UnitTests.Functions;
+
 public class KernelFunctionMetadataFactoryTests
 {
     [Fact]
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,7 @@ @@
     using Xunit;
     namespace SemanticKernel.UnitTests.Functions;
     public class KernelFunctionMetadataFactoryTests
     {
         [Fact]
@@ Expand Down @@