Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Add VectorStoreTextSearch concepts and unit tests #8891

Merged
merged 3 commits into from
Sep 23, 2024
Merged

.Net: Add VectorStoreTextSearch concepts and unit tests #8891

merged 3 commits into from
Sep 23, 2024

Conversation

markwallace-microsoft
Copy link
Member

@markwallace-microsoft markwallace-microsoft commented Sep 18, 2024 •
edited
Loading

Motivation and Context

  1. Add VectorizedSearchWrapper to help test VectorStoreTextSearch
  2. Add unit tests for VectorStoreTextSearch

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner September 18, 2024 11:37
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Sep 18, 2024
@github-actions github-actions bot changed the title Add VectorizedSearchWrapper to help test VectorStoreTextSearch .Net: Add VectorizedSearchWrapper to help test VectorStoreTextSearch Sep 18, 2024
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Sep 18, 2024
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/vectorized_search_wrapper branch from d738c72 to 7dcffc4 Compare September 19, 2024 16:27
@markwallace-microsoft markwallace-microsoft changed the title .Net: Add VectorizedSearchWrapper to help test VectorStoreTextSearch .Net: Add VectorStoreTextSearch concepts and unit tests Sep 20, 2024
@RogerBarreto
Copy link
Member

Does this change eliminates MemoryStore + SemanticTextMemory + TextMemoryPlugin, if positive, would be nice to see OnnxSimpleRAG Demo, updated to the new abstractions.

@markwallace-microsoft
Copy link
Member Author

Does this change eliminates MemoryStore + SemanticTextMemory + TextMemoryPlugin, if positive, would be nice to see OnnxSimpleRAG Demo, updated to the new abstractions.

We have this task to track RAG samples #7350

@markwallace-microsoft markwallace-microsoft merged commit 6c4aa5d into microsoft:feature-vector-search Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westey-m westey-m westey-m approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markwallace-microsoft @RogerBarreto @westey-m