-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Streaming content for token usage #8902
Python: Streaming content for token usage #8902
Conversation
Proposal 3 and 4 came from an offline discussion. They do include a refactoring of the existing content classes, which is not necessary for handling streaming usage information from OAI. However, I do like those two proposals as they further clean up our code base. Out of the two, I think proposal 4 is cleaner. |
Upon further deliberation, I think that deprecating
|
This reverts commit 7e170fa.
Python Test Coverage ReportPython Unit Test Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation and Context
OpenAI recently starts providing token usage information on their streaming chat completion API. This ADR opens the discussion on how we should consume that information within our
StreamingChatMessageContent
data structure.Description
__add__
).Contribution Checklist