Python: enable ollama streaming tool calls #9890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
eavanvalkenburg
force-pushed
the
ollama_fix
branch
from
2ae923b to
41911cd
Compare
alliscode
approved these changes
Dec 5, 2024
TaoChenOSU
reviewed
Dec 5, 2024
python/semantic_kernel/connectors/ai/ollama/services/ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
force-pushed
the
ollama_fix
branch
from
c3922f5 to
508a7e5
Compare
TaoChenOSU
reviewed
Dec 6, 2024
TaoChenOSU
reviewed
Dec 6, 2024
python/semantic_kernel/connectors/ai/ollama/services/ollama_chat_completion.py
Show resolved
Hide resolved
TaoChenOSU
approved these changes
Dec 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
moonbox3
approved these changes
Dec 7, 2024
eavanvalkenburg
force-pushed
the
ollama_fix
branch
from
7b1d811 to
d86e000
Compare
moonbox3
approved these changes
Dec 9, 2024
eavanvalkenburg
force-pushed
the
ollama_fix
branch
from
1e51d85 to
f8e63fc
Compare
moonbox3
approved these changes
Dec 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alliscode
approved these changes
Dec 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Ollama has enabled streaming tool calling, and so we add that too!
See release notes: https://github.com/ollama/ollama/releases/tag/v0.4.6
Also encountered a bug when passing generic PromptExecutionSettings to all ChatCompletions with Function calling enabled, the _verify_function_choice_settings often check if something is a type of PES matching the service, that is not the case and throws even though it should work (for instance when using a yaml based function), this fixes that as well by casting in the public methods of chat completion base.
Description
Contribution Checklist