Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: improving build tools installation #207

Merged

Conversation

arthuraraujo-msft
Copy link
Contributor

@arthuraraujo-msft arthuraraujo-msft commented Sep 4, 2024

Related Issues

Why is this change being made?

I went to run setup & build after some time not using cmake and faced an issue with my build tools not being found.
Running setup again did not help either. Turns out I had to manually call vcpkg bootstrap so it set up the latest build tools on its folder so it could be found.

What is being changed?

  • Installing vswhere and using it to auto-detect during the setup script there are currently installed VS build tools with the required C++ build components.
  • Using --quiet to make the installation silent.
  • Calling vcpkg bootstrap on all setup runs to avoid these kinds of issues.
  • -NoBuildTools is no longer needed.

How was the change tested?

  • Not a functional change. Modifying auxiliary files.
  • Ran the setup script a few times locally to test it. It's no longer installing build tools if they're not needed.

@arthuraraujo-msft arthuraraujo-msft requested a review from a team as a code owner September 4, 2024 13:46
@arthuraraujo-msft arthuraraujo-msft merged commit ab8f0e7 into main Sep 5, 2024
3 checks passed
@arthuraraujo-msft arthuraraujo-msft deleted the user/arthuraraujo/setup-improving-build-tools branch September 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup.ps1 operation fails on Installing C++ Build Tools if already installed.
1 participant