Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding required permissions to enable uploading of CodeQL results #214

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

ogbolade-msft
Copy link
Contributor

@ogbolade-msft ogbolade-msft commented Nov 14, 2024

Related Issues

Why is this change being made?

Although pr build succeeded, the builds triggered after merge of the change to enable CodeQL failed due to some missing permission needed to upload the CodeQL scan results.

What is being changed?

-Adding the required permissions.
-There was also a warning about codeql-action version v2 getting deprecated in December, hence the version is bumped to v3

How was the change tested?

Will verify from the build after merge

@ogbolade-msft ogbolade-msft requested a review from a team as a code owner November 14, 2024 21:46
@arthuraraujo-msft
Copy link
Contributor

@ogbolade-msft please create a new bug in the repo to track the issue and connect it here.

@arthuraraujo-msft
Copy link
Contributor

arthuraraujo-msft commented Nov 18, 2024

Can you add a link to the doc explaining that this is the solution for the issue (if it's a public CodeQL doc)?

@arthuraraujo-msft arthuraraujo-msft merged commit 216210a into main Nov 21, 2024
4 checks passed
@arthuraraujo-msft arthuraraujo-msft deleted the user/ogbolade/enable-codeql branch November 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Permissions issue with uploading CodeQL results
2 participants