Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute to SCM Graph item context menu (proposed API in 1.94) #6239

Closed
wants to merge 2 commits into from
Closed

Contribute to SCM Graph item context menu (proposed API in 1.94) #6239

wants to merge 2 commits into from

Conversation

gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Sep 20, 2024 •
edited
Loading

This PR implements #6236

@gjsjohnmurray
Copy link
Contributor Author

image

@gjsjohnmurray
Copy link
Contributor Author

Looks like something needs to be done at the VS Code end to "bless" this extension's use of another proposed API.

image

@alexr00
Copy link
Member

alexr00 commented Sep 23, 2024

@lszomoru is it ok if GHPR uses contribSourceControlHistoryItemMenu?

@lszomoru
Copy link
Member

These actions should be contributed through the built-in github extension. Filed microsoft/vscode#229349 to track this.

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru good point. I had overlooked that there's a built-in GH one too. If I reimplement this PR over there will you consider taking it?

@lszomoru
Copy link
Member

Sure, please go ahead. This is something for next milestone though...

@gjsjohnmurray
Copy link
Contributor Author

Replaced by microsoft/vscode#229386

@gjsjohnmurray gjsjohnmurray deleted the do-6236 branch September 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjsjohnmurray @alexr00 @lszomoru