Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #236973 #236974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #236973 #236974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/chat/common/languageModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export interface ILanguageModelChat {

export interface ILanguageModelChatSelector {
readonly name?: string;
readonly identifier?: string;
readonly id?: string;
readonly vendor?: string;
readonly version?: string;
readonly family?: string;
Expand Down Expand Up @@ -264,7 +264,7 @@ export class LanguageModelsService implements ILanguageModelsService {
if ((selector.vendor === undefined || model.metadata.vendor === selector.vendor)
&& (selector.family === undefined || model.metadata.family === selector.family)
&& (selector.version === undefined || model.metadata.version === selector.version)
&& (selector.identifier === undefined || model.metadata.id === selector.identifier)
&& (selector.id === undefined || model.metadata.id === selector.id)
&& (!model.metadata.targetExtensions || model.metadata.targetExtensions.some(candidate => ExtensionIdentifier.equals(candidate, selector.extension)))
) {
result.push(identifier);
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/chat/test/common/languageModels.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ suite('LanguageModels', function () {
}
}));

const models = await languageModels.selectLanguageModels({ identifier: 'actual-lm' });
const models = await languageModels.selectLanguageModels({ id: 'actual-lm' });
assert.ok(models.length === 1);

const first = models[0];
Expand Down