Skip to content

Commit

Permalink
remove removed deprecated sass code following the mixed-decls rule
Browse files Browse the repository at this point in the history
poojagunturu96 committed Jan 7, 2025
1 parent 65962a2 commit 9ec77c4
Showing 16 changed files with 34 additions and 27 deletions.
3 changes: 2 additions & 1 deletion src/scss/components/_anchor-header.scss
Original file line number Diff line number Diff line change
@@ -38,9 +38,10 @@
}

.anchor-header__title {
@include type.h0;
font-family: variables.$font-family-serif;
margin-bottom: variables.$spacing-3;

@include type.h0;
}

.anchor-header__link {
4 changes: 3 additions & 1 deletion src/scss/components/_app-header.scss
Original file line number Diff line number Diff line change
@@ -12,12 +12,14 @@ $app-header-bp: lg;
}

.app-header__wrap {
@include grid.make-container;
display: flex;

@include grid.make-container;

@media print {
display: block;
}

}

.app-header__wrap--main {
2 changes: 1 addition & 1 deletion src/scss/components/_card-carousel-item.scss
Original file line number Diff line number Diff line change
@@ -157,7 +157,7 @@ $card-carousel-item-colors: (
);

@each $key, $hex in $card-carousel-item-colors {
.card-carousel-item__header--#{$key} {
.card-carousel-item__header--#{"" + $key} {
background: rgba($hex, 0.9);
}
}
3 changes: 2 additions & 1 deletion src/scss/components/_card-carousel.scss
Original file line number Diff line number Diff line change
@@ -25,10 +25,11 @@ $card-carousel-height: 600px;

.card-carousel__title {
color: variables.$white;
@include type.h0;
// line-height: $h1-line-height;
margin-bottom: 1rem;

@include type.h0;

@include breakpoints.breakpoint(md) {
margin-bottom: 3rem;
}
2 changes: 1 addition & 1 deletion src/scss/components/_chart.scss
Original file line number Diff line number Diff line change
@@ -17,8 +17,8 @@
}

.chart-group__item {
@include grid.make-col-ready;
margin-bottom: variables.$spacing-5;
@include grid.make-col-ready;

// TODO: clever class names we should change to pass stylelint class pattern
// stylelint-disable-next-line
4 changes: 2 additions & 2 deletions src/scss/components/_cta-group.scss
Original file line number Diff line number Diff line change
@@ -15,10 +15,10 @@
}

.cta-group__item {
@include grid.make-col-ready;
padding-top: variables.$spacing-4;
padding-bottom: variables.$spacing-4;
text-align: center;
@include grid.make-col-ready;

@include breakpoints.breakpoint(md) {
padding-top: variables.$spacing-5;
@@ -69,8 +69,8 @@
}

.cta-group__title {
@include type.h2;
margin-bottom: variables.$spacing-2;
@include type.h2;
}

.cta-group__text {
8 changes: 5 additions & 3 deletions src/scss/components/_davis-header.scss
Original file line number Diff line number Diff line change
@@ -51,8 +51,10 @@
}
}

padding-top: variables.$spacing-3;
padding-bottom: variables.$spacing-3;
& {
padding-top: variables.$spacing-3;
padding-bottom: variables.$spacing-3;
}

@include breakpoints.breakpoint(md) {
padding-top: variables.$spacing-4;
@@ -99,9 +101,9 @@
}

.davis-nav {
@include mixins.print-hide;
display: none;

@include mixins.print-hide;
@include breakpoints.breakpoint(xl) {
display: initial;
}
2 changes: 1 addition & 1 deletion src/scss/components/_grid.scss
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@

.container {
@include grid.make-container;

@media print {
padding-left: 0;
padding-right: 0;
5 changes: 2 additions & 3 deletions src/scss/components/_journey.scss
Original file line number Diff line number Diff line change
@@ -491,16 +491,15 @@

h1 {
font-size: variables.$typescale-7;

font-weight: variables.$font-weight-light;

@include breakpoints.breakpoint(lg) {
font-size: functions.rem(40);
}

@include breakpoints.breakpoint(xl) {
font-size: variables.$typescale-9;
}

font-weight: variables.$font-weight-light;
}

p.sub-title {
3 changes: 2 additions & 1 deletion src/scss/components/_midd-header.scss
Original file line number Diff line number Diff line change
@@ -25,9 +25,10 @@
}

.midd-header__container {
@include grid.make-container;
position: relative;
display: flex;

@include grid.make-container;
}

.midd-header__brand {
7 changes: 4 additions & 3 deletions src/scss/components/_office-footer.scss
Original file line number Diff line number Diff line change
@@ -15,24 +15,25 @@
}

.office-footer__row {
@include grid.make-row;
justify-content: center;
@include grid.make-row;
}

.office-footer__col {
@include grid.make-col-ready;
padding-bottom: variables.$spacing-4;
padding-top: variables.$spacing-4;

@include grid.make-col-ready;

@include breakpoints.breakpoint(md) {
padding-bottom: variables.$spacing-5;
padding-top: variables.$spacing-5;
}

@include breakpoints.breakpoint(lg) {
@include grid.make-col(4);
padding-top: 0;
padding-bottom: 0;
@include grid.make-col(4);
}

&:not(:last-child) {
2 changes: 1 addition & 1 deletion src/scss/components/_page-header.scss
Original file line number Diff line number Diff line change
@@ -209,9 +209,9 @@
}

.page-header__content {
@include grid.make-col-ready;
padding-top: variables.$spacing-5;
padding-bottom: variables.$spacing-4;
@include grid.make-col-ready;

@include breakpoints.breakpoint(md) {
padding-top: variables.$spacing-6;
10 changes: 5 additions & 5 deletions src/scss/components/_school-footer.scss
Original file line number Diff line number Diff line change
@@ -41,18 +41,18 @@
}

.school-footer__secondary {
@include grid.make-col-ready;
padding-top: variables.$spacing-5;
padding-bottom: variables.$spacing-5;
@include grid.make-col-ready;

@include breakpoints.breakpoint(md) {
@include grid.make-col(4);
margin-left: auto;
@include grid.make-col(4);
}

@include breakpoints.breakpoint(lg) {
@include grid.make-col(12);
padding-bottom: 0;
@include grid.make-col(12);
}

.school-footer--lite & {
@@ -70,18 +70,18 @@
}

.school-footer__text {
@include type.h0;
color: variables.$white;
margin-bottom: variables.$spacing-4;
@include type.h0;

@include breakpoints.breakpoint(md) {
margin-bottom: variables.$spacing-5;
}
}

.school-footer__nav {
@include grid.make-col-ready;
border-top: 1px solid variables.$navy-light;
@include grid.make-col-ready;

@include breakpoints.breakpoint(md) {
margin-top: variables.$spacing-5;
2 changes: 1 addition & 1 deletion src/scss/components/_spotlight.scss
Original file line number Diff line number Diff line change
@@ -48,11 +48,11 @@
}

.spotlight__title {
@include type.h0;
background: variables.$color-primary;
color: variables.$white;
padding-top: variables.$spacing-4;
padding-bottom: variables.$spacing-4;
@include type.h0;

@include breakpoints.breakpoint(md) {
// fake column offset with padding plus gutter width
2 changes: 1 addition & 1 deletion src/scss/components/_tabs.scss
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
.tabs__nav {
position: relative;
right: 0;
margin: 0 -(variables.$spacing-3);
margin: 0 (-(variables.$spacing-3));

@include breakpoints.breakpoint(md) {
margin: 0;
2 changes: 1 addition & 1 deletion src/scss/pardot-forms.scss
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@
select,
textarea,
input[type='text'] {
@include forms.form-control;
padding: variables.$spacing-2;
@include forms.form-control;
}

select {

0 comments on commit 9ec77c4

Please sign in to comment.