Update to BTN API #982
Open
Update to BTN API #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you shouldnt change the line endings.. aka it shows you modified the whole file.... which makes it hard to see actual changes and will most likely delay this from ever getting pulled |
|
Apologies, I'm new to this. Is there a way to just show the changed line? |
|
I have the following error: 2017-03-02 14:52:30 SEARCHQUEUE-MANUAL-SEARCH :: Unknown error while accessing BTN: 'SafeTransport' object has no attribute 'context' |
|
@noone5 for that joshmarshall/jsonrpclib#36 is needed jsonrpclib should be updated as well. Luckily BTN is the only provider that uses it so that simplifies testing. |
Closed
|
scrap this in favour of #984 which is a more elegant fix |
ekohl
added a commit
to ekohl/Sick-Beard
that referenced
this pull request
Jul 1, 2017
This is midgetspy#982 but without all the whitespace changes. It depends on bumping jsonrpclib for proper https support. midgetspy#984 does update the URL but doesn't switch to HTTPS.
ekohl
added a commit
to ekohl/Sick-Beard
that referenced
this pull request
Jul 1, 2017
This is midgetspy#982 but without all the whitespace changes. It depends on bumping jsonrpclib for proper https support. midgetspy#984 does update the URL but doesn't switch to HTTPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.