fix UT failures and code check breaks

Signed-off-by: Ted Xu <[email protected]>
milvus-io · Jan 6, 2025 · 948a29f · 948a29f
1 parent b574767
commit 948a29f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/internal/flushcommon/syncmgr/pack_writer.go b/internal/flushcommon/syncmgr/pack_writer.go
@@ -203,10 +203,10 @@ func (bw *BulkPackWriter) writeStats(ctx context.Context, pack *SyncPack) (map[i
 
 	pkFieldID := serializer.pkField.GetFieldID()
 	binlogs := make([]*datapb.Binlog, 0)
-	if batchStatsBlob, err := bw.writeLog(ctx, batchStatsBlob, common.SegmentStatslogPath, pack, pkFieldID, bw.nextID()); err != nil {
+	if binlog, err := bw.writeLog(ctx, batchStatsBlob, common.SegmentStatslogPath, pack, pkFieldID, bw.nextID()); err != nil {
 		return nil, err
 	} else {
-		binlogs = append(binlogs, batchStatsBlob)
+		binlogs = append(binlogs, binlog)
 	}
 
 	if pack.isFlush && pack.level != datapb.SegmentLevel_L0 {
@@ -215,11 +215,11 @@ func (bw *BulkPackWriter) writeStats(ctx context.Context, pack *SyncPack) (map[i
 			return nil, err
 		}
 
-		if mergedStatsBlob, err := bw.writeLog(ctx, mergedStatsBlob, common.SegmentStatslogPath, pack, pkFieldID, int64(storage.CompoundStatsType)); err != nil {
+		binlog, err := bw.writeLog(ctx, mergedStatsBlob, common.SegmentStatslogPath, pack, pkFieldID, int64(storage.CompoundStatsType))
+		if err != nil {
 			return nil, err
-		} else {
-			binlogs = append(binlogs, mergedStatsBlob)
 		}
+		binlogs = append(binlogs, binlog)
 	}
 
 	logs := make(map[int64]*datapb.FieldBinlog)

diff --git a/internal/flushcommon/writebuffer/l0_write_buffer_test.go b/internal/flushcommon/writebuffer/l0_write_buffer_test.go
@@ -208,16 +208,6 @@ func (s *L0WriteBufferSuite) TestBufferData() {
 	})
 }
 
-func (s *L0WriteBufferSuite) TestCreateFailure() {
-	metacache := metacache.NewMockMetaCache(s.T())
-	metacache.EXPECT().Collection().Return(s.collID)
-	metacache.EXPECT().Schema().Return(&schemapb.CollectionSchema{})
-	_, err := NewL0WriteBuffer(s.channelName, metacache, s.syncMgr, &writeBufferOption{
-		idAllocator: s.allocator,
-	})
-	s.Error(err)
-}
-
 func TestL0WriteBuffer(t *testing.T) {
 	suite.Run(t, new(L0WriteBufferSuite))
 }