Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add some apis in Restful(#38733) #38875

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Dec 31, 2024

issue: #38709
pr: #38733 #38979

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon smellthemoon changed the title enhance: add some apis in Restful enhance: add some apis in Restful(#38733) Dec 31, 2024
@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 31, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 87.59690% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (055cbe1) to head (cb3946b).
Report is 2 commits behind head on 2.5.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/request_v2.go 23.80% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38875       +/-   ##
===========================================
+ Coverage   69.45%   81.05%   +11.59%     
===========================================
  Files         294     1383     +1089     
  Lines       26419   195647   +169228     
===========================================
+ Hits        18349   158575   +140226     
- Misses       8070    31491    +23421     
- Partials        0     5581     +5581     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.45% <ø> (ø)
Go 83.03% <87.59%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.95% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/request_v2.go 81.81% <23.80%> (ø)

... and 1087 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 31, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 31, 2024
@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 3, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added ci-passed and removed ci-passed labels Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants