Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update typo in "Welcome to Milvus" #38995

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

franciscojavierarceo
Copy link
Contributor

@franciscojavierarceo franciscojavierarceo commented Jan 3, 2025

enhance: Updating a minor typo.

@sre-ci-robot
Copy link
Contributor

Welcome @franciscojavierarceo! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot requested review from cydrain and yhmo January 3, 2025 20:27
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@franciscojavierarceo Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@franciscojavierarceo

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo changed the title Update typo in Welcome to Milvus doc: Update typo in Welcome to Milvus Jan 3, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jan 3, 2025
@franciscojavierarceo franciscojavierarceo changed the title doc: Update typo in Welcome to Milvus doc: Update typo in "Welcome to Milvus" Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@franciscojavierarceo go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (11bfc93) to head (05c6aec).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (11bfc93) and HEAD (05c6aec). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (11bfc93) HEAD (05c6aec)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38995       +/-   ##
===========================================
- Coverage   81.14%   69.53%   -11.61%     
===========================================
  Files        1388      296     -1092     
  Lines      196471    26540   -169931     
===========================================
- Hits       159418    18455   -140963     
+ Misses      31465     8085    -23380     
+ Partials     5588        0     -5588     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.53% <ø> (ø)
Go ∅ <ø> (∅)

see 1092 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 5, 2025
@sre-ci-robot sre-ci-robot merged commit 7f05d7a into milvus-io:master Jan 5, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/doc lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants