Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add broadcast operation for msgstream #39040

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 7, 2025

issue: #38399

  • make broadcast service available for msgstream by reusing the architecture streaming service

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 59.39086% with 80 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (86d665a) to head (d108b10).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/broadcast_task.go 8.77% 52 Missing ⚠️
...treaming/util/message/adaptor/broadcast_message.go 0.00% 12 Missing ⚠️
pkg/streaming/util/types/responses.go 86.04% 6 Missing ⚠️
internal/distributed/streaming/util.go 55.55% 4 Missing ⚠️
internal/rootcoord/dml_channels.go 0.00% 3 Missing ⚠️
...eamingcoord/server/broadcaster/broadcaster_impl.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #39040    +/-   ##
========================================
  Coverage   81.13%   81.14%            
========================================
  Files        1395     1400     +5     
  Lines      197359   197492   +133     
========================================
+ Hits       160131   160245   +114     
- Misses      31599    31633    +34     
+ Partials     5629     5614    -15     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.64% <ø> (ø)
Go 83.06% <59.18%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/distributed/streaming/streaming.go 100.00% <100.00%> (ø)
internal/distributed/streaming/wal.go 66.08% <100.00%> (+1.22%) ⬆️
internal/rootcoord/root_coord.go 90.09% <100.00%> (+0.01%) ⬆️
internal/streamingcoord/client/client.go 97.01% <100.00%> (+0.18%) ⬆️
internal/streamingcoord/client/client_impl.go 80.00% <100.00%> (+5.00%) ⬆️
...ord/server/broadcaster/registry/append_operator.go 100.00% <100.00%> (ø)
...gcoord/server/broadcaster/registry/test_utility.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/broadcaster/task.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/server.go 71.69% <100.00%> (ø)
pkg/streaming/util/types/streaming_node.go 82.35% <ø> (-2.50%) ⬇️
... and 8 more

... and 32 files with indirect coverage changes

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream branch 2 times, most recently from 93ba8ee to c326987 Compare January 9, 2025 09:57
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Jan 9, 2025
@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream branch from c326987 to ed8bcbc Compare January 10, 2025 06:06
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream branch from ed8bcbc to cce11fc Compare January 10, 2025 07:17
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream branch from cce11fc to 96f423c Compare January 10, 2025 09:20
- make broadcast service available for msgstream by reusing the architecture streaming service

Signed-off-by: chyezh <[email protected]>
Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_add_broadcast_for_msgstream branch from 96f423c to d108b10 Compare January 10, 2025 11:56
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Jan 11, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 11, 2025
sre-ci-robot pushed a commit that referenced this pull request Jan 14, 2025
issue: #38399
pr: #39040

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <[email protected]>
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fd84ed8 into milvus-io:master Jan 14, 2025
19 of 20 checks passed
@chyezh chyezh deleted the enhance_add_broadcast_for_msgstream branch January 14, 2025 07:15
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
issue: milvus-io#38399

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants