change "repeat" to "repeat_interleave" and "tile" uniformly #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2025 15:28
Songyuanwei
requested review from
CaitinZhao,
SamitHuang,
zhanghuiyao and
vigo999
as code owners
Songyuanwei
changed the title
wtomin
reviewed
Jan 21, 2025
examples/opensora_pku/opensora/models/causalvideovae/model/modules/quant.py
Show resolved
Hide resolved
hqkate
reviewed
Jan 22, 2025
6 tasks
added 2 commits
January 22, 2025 17:44
CaitinZhao
reviewed
Jan 23, 2025
| @@ -49,7 +49,7 @@ def transform_conditional_images(image_paths, H, W, random_crop=True, normalize= | |||
| if normalize: | |||
|
|
|||
| def image_norm(image): | |||
| image = image.mean(dim=0, keepdim=True).repeat(3, 1, 1) | |||
| image = image.mean(axis=0, keepdims=True).repeat(3, axis=0) | |||
There was a problem hiding this comment.
repeat(3, 1, 1) -> tile(3, 1, 1)?
There was a problem hiding this comment.
这个是numpy的mean和repeat，这里做了下参数修改。torch的repeat(3,1,1)和numpy的repeat(3,axis=0)对于(1, H, W)的image的生成结果是一样的。
CaitinZhao
approved these changes
Feb 5, 2025
SamitHuang
approved these changes
Feb 5, 2025
|
there is nothing under "What does this PR do". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Since
mindspore.Tensor.repeatis different from thetorch.Tensor.repeatfor now, we check the original torch source code again and replace themindspore.Tensor.repeatwithmindspore.Tensor.repeat_interleaveormindspore.Tensor.tileaccording to the following alignment rules:torch.Tensor.repeat->mindspore.Tensor.tiletorch.Tensor.repeat_interleave->mindspore.Tensor.repeat_interleaveBefore submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx