Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements files and aligning with new GDS updates and designs #19

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

psweeting1
Copy link
Collaborator

@psweeting1 psweeting1 commented Dec 13, 2024

Summary:
This PR includes updates to dependencies and improvements to the demo shell script for better compatibility and styling.

Changes:

Requirements File Updates:

  • Bumped dependency versions in requirements.txt and related files to ensure compatibility with the latest versions.
  • Upgraded the GDS frontend package to the latest version, allowing the project to utilise newer CSS and JS features.
  • Demo Shell Script Fix. Updated the demo shell script to reference the correct stylesheets, ensuring accurate styling in demos.

Why These Changes Are Necessary:

  • Keeps dependencies up to date for security and stability.
  • Allows the use of improved GDS frontend components and styles.
  • Fixes inconsistencies in demo styling caused by outdated references.

Testing

  • Confirmed that the project builds successfully with the updated dependencies.
  • Verified that the latest GDS frontend styles and scripts integrate without issues.
  • Tested the demo shell script to ensure correct stylesheet loading.

requirements_dev.txt Outdated Show resolved Hide resolved
requirements_dev.txt Outdated Show resolved Hide resolved
Updating requirments files and aligning with new GDS updates and designs
@psweeting1 psweeting1 force-pushed the feature/packages-and-gds-updates branch from 120df2c to ef2abc2 Compare December 16, 2024 08:28
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psweeting1 psweeting1 merged commit 402d800 into main Dec 16, 2024
@psweeting1 psweeting1 deleted the feature/packages-and-gds-updates branch December 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants