Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup map for GEO IP #3242

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Setup map for GEO IP #3242

wants to merge 5 commits into from

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Jul 17, 2024

Changes

  • Add url, view and template to show map
  • Implemented map with MapLibre GL JS + CSS. Setup docs: https://maplibre.org/maplibre-gl-js/docs/
  • Use OSM Bright styling. This is exported as a json document by UX'ers called bright.json
  • In bright.json we have all the styling defined for:
  • Openmap tiles, sprite images and glyphs from maptiler.com.
  • Created API key at https://cloud.maptiler.com/
  • See map at this url: http://localhost:8000/en/{organization_code}/reports/view/location-report/
  • Created map containers where we can add multiple maps in 1 view (for example concatenated report/ aggregate report)

Questions about this feature

  • If we are hosting our own files for this version then we need to point to specific files, for example json files, sprites, tiles, glyphs and .pbf files
  • For example we have: https://api.maptiler.com/fonts/{fontstack}/{range}.pbf?key=KuM0vKEfWZcZRqsETQg5 which is defined in bright.json uses certain variables to fetch a range of .pbf files. If are going to host it we must also create all these ranges. See also fontstack variable. Here it uses an API key which will further cascade to fetching other necessary files using this API KEY.

Issue link

#3243

Closes #3243

Demo

image

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven self-assigned this Aug 28, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
63.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maps to rocky to work with GEO IP
1 participant