Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused queue_uri from boefje settings #4068

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Feb 6, 2025

Changes

Remove the queue_uri from boefje settings. This was a required field but boefjes/normalizers/katalogus doesn't use RabbitMQ.

QA notes

The queue uri was never used in the code so there is not much too test.
Boefjes and normalizers should still work.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner February 6, 2025 11:22
@dekkers dekkers self-assigned this Feb 6, 2025
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Looks good. Onboarding worked, manually enabled another boefje and they all complete. Normalizers run and the Onboarding report is created.

What doesn't work:

n/a

Bug or feature?:

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

4 participants