Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: expose skip exception #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Khady
Copy link

@Khady Khady commented Dec 23, 2024

Fix #415

@@ -268,4 +268,4 @@ let match_raises ?here ?pos msg exnp f =
Fmt.pf ppf "%t%a %s: got %a." (pp_location ?here ?pos) Pp.tag `Fail
msg Fmt.exn e)

let skip () = raise Core.Skip
let skip () = raise Core.V1.Skip
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't too sure if test.ml was suppose to depend on V1 or not.

Copy link
Collaborator

@MisterDA MisterDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Skip exception
2 participants