Update Tar_eio #159
Open
Update Tar_eio #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements missing functionality in Tar_eio and also tidies up the interfaces to the library itself.
|
We should add some tests for the Eio backend |
|
LGTM - would be nice to add a few tests before merging |
|
Any plans to "add a few tests"? I'm concerned that this PR will otherwise miss the release window. We can as well merge and you can propose tests in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements missing functionality in Tar_eio and also tidies up the interfaces to the library itself.
Most of this is borrowed from
lwtversion of the library and ported to Eio primitives. The Eio portion of the library is not tested anywhere which I'm looking into.