-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(backend): 絵文字の連合でライセンス欄を相互にやり取りするように #15182
enhance(backend): 絵文字の連合でライセンス欄を相互にやり取りするように #15182
Conversation
Co-authored-by: Kisaragi Marine <[email protected]> Co-authored-by: ruruke <[email protected]>
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15182 +/- ##
===========================================
- Coverage 39.42% 39.42% -0.01%
===========================================
Files 1568 1568
Lines 199065 199077 +12
Branches 3645 3645
===========================================
+ Hits 78484 78485 +1
- Misses 120008 120019 +11
Partials 573 573 ☔ View full report in Codecov by Sentry. |
(Conflict解消しておきました) |
f45fd01
into
misskey-dev:develop
Thank you 🙏 |
* enhance(backend): 絵文字の連合でライセンス欄を相互にやり取りするように Co-authored-by: Kisaragi Marine <[email protected]> Co-authored-by: ruruke <[email protected]> * fix CHANGELOG.md --------- Co-authored-by: Kisaragi Marine <[email protected]> Co-authored-by: ruruke <[email protected]> Co-authored-by: taichan <[email protected]> Co-authored-by: syuilo <[email protected]>
なお、内部にfreeTextを持たせる仕様は、将来に向けて_misskey_licenseを拡張できるようにしているのだと思いますが、ライセンス廻りの詳細なプロパティの追加はEmojiの直下に項目追加する方向で良いと思います。ついては、_misskey_licenseにfreeTextなしで直接値を持たせた方が明快でいいんじゃないかな。 こんな感じ。
|
What
resolve #10859
※ #14109 のサルベージ版です
Why
issueの通り
Additional info (optional)
ローカルのVM同士で実際にライセンスが連合されることを確認
_misskey_license
が含まれていることrelated ap: purpose _misskey_license on Emoji misskey-hub-next#278
Checklist