Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Authorization headers not showing on kulala.inspect #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

estacioneto
Copy link

As the title says, it fixes the issue where the headers were not shown on kulala.inspect, which would make kulala.run not work inside the inspect buffer.

The problem was described at #122

@gorillamoe
Copy link
Member

I think that would cause a regression, any thoughts about this PR @Grueslayer? I see the point that inspect not showing the auth headers, but I don't think that this is the "right" approach.

@Grueslayer
Copy link
Contributor

The Authorization header is only removed from the header table when it should be handled by Curl itself (like for BASIC-User-Password / NTLM ....) but for other cases where there is no additional handling needed (like BEARER or BASIC where the Username and Passwort was already Base64-encoded) it keeps in the header list and still must be forwarded to Curl as header.

So the solution needs to be a little bit different, I'll have a look at it in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants