check if process is system

mitmproxy · Dec 19, 2024 · f3773dc · f3773dc
1 parent 69bc397
commit f3773dc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/processes/linux_list.rs b/src/processes/linux_list.rs
@@ -26,15 +26,20 @@ pub fn active_executables() -> Result<ProcessList> {
                     let executable = e.key().clone();
                     // .file_name() returns `None` if the path terminates in `..`
                     // We use the absolute path in such a case.
-                    let display_name = match path.file_name() {
-                        Some(s) => s.to_string_lossy().to_string(),
-                        None => path.to_string_lossy().to_string(),
+                    let display_name = path
+                        .file_name()
+                        .unwrap_or(path.as_os_str())
+                        .to_string_lossy()
+                        .to_string();
+                    let is_system = match process.effective_user_id() {
+                        Some(id) => id.to_string() == "0",
+                        None => false,
                     };
                     e.insert(ProcessInfo {
                         executable,
                         display_name,
                         is_visible: false,
-                        is_system: false,
+                        is_system,
                     });
                 }
             }

diff --git a/src/processes/macos_list.rs b/src/processes/macos_list.rs
@@ -42,12 +42,16 @@ pub fn active_executables() -> Result<ProcessList> {
                     let executable = e.key().clone();
                     // .file_name() returns `None` if the path terminates in `..`
                     // We use the absolute path in such a case.
-                    let display_name = match path.file_name() {
-                        Some(s) => s.to_string_lossy().to_string(),
-                        None => path.to_string_lossy().to_string(),
+                    let display_name = path
+                        .file_name()
+                        .unwrap_or(path.as_os_str())
+                        .to_string_lossy()
+                        .to_string();
+                    let is_system = match process.effective_user_id() {
+                        Some(id) => id.to_string() == "0",
+                        None => false,
                     };
                     let is_visible = visible.contains(&pid);
-                    let is_system = executable.starts_with("/System/");
                     e.insert(ProcessInfo {
                         executable,
                         display_name,