Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if process is system on linux #205

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Check if process is system on linux #205

merged 14 commits into from
Dec 23, 2024

Conversation

errorxyz
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@errorxyz errorxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a WIP, I've added a few questions before moving forward:

src/processes/linux_list.rs Outdated Show resolved Hide resolved
src/processes/linux_list.rs Outdated Show resolved Hide resolved
@errorxyz errorxyz changed the title Check if process is system or visible (for x11 only) on linux Check if process is system on linux Dec 19, 2024
@errorxyz errorxyz marked this pull request as ready for review December 19, 2024 10:59
@errorxyz errorxyz requested a review from mhils December 19, 2024 11:00
@errorxyz
Copy link
Contributor Author

errorxyz commented Dec 19, 2024

Is there a reason why windows_list.rs does not use the sysinfo crate? We can use the sysinfo crate to get all process-related information except is_system and is_visible for windows

src/processes/nix_list.rs Outdated Show resolved Hide resolved
src/processes/nix_list.rs Outdated Show resolved Hide resolved
src/processes/nix_list.rs Outdated Show resolved Hide resolved
@mhils
Copy link
Member

mhils commented Dec 19, 2024

Is there a reason why windows_list.rs does not use the sysinfo crate? We can use the sysinfo crate to get all process-related information except is_system and is_visible for windows

I think the second sentence answers the question in the first one. Let's keep the Windows implementation as-is, that one is fairly well tested in practice. :)

@errorxyz errorxyz requested review from mhils and decathorpe December 21, 2024 08:09
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🍰

@mhils mhils merged commit 6028f0b into mitmproxy:main Dec 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants