Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce @public marker to explicitly mark members as public #655
Introduce @public marker to explicitly mark members as public #655
Changes from 8 commits
7ac6ed3
77a8a1c
5df57c7
4ed4b8f
f3a909d
0e8bb8d
85b3d80
66c4b07
9744712
fd1f3c8
47edb46
a080d2f
20ce253
826cea2
a09d961
a429dd8
f8e7b61
0758afc
6efdadc
1d9c2c8
6d5404b
2fd0fd2
2702a1c
50bacc4
dd8bb40
556837e
02afd0a
7d360ad
78e0d94
631e455
0c08f4a
78dd126
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I don't fully understand why there is a second public method here. What are we verifying with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to see if there is any unwanted whitespace after the docstring in the generated html. The second method is there only to see how much spacing between methods you get regularly. For the automated test suite it's probably not really useful.