Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN location of mermaid from v10 to v11 #763

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

CodeMelted
Copy link
Contributor

I discovered your product and it is awesome. However noticed that mermaid (one of the awesome features you provide) is on v10. This will bring it up to v11. In the tests I ran for rendering mermaid documents it supports the upgraded mermaid syntax / styling.

Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🍰

@mhils mhils merged commit a939ab1 into mitmproxy:main Nov 29, 2024
14 checks passed
@joshuai96
Copy link

Happy to see the update. Currently seeing Syntax error in text with the used mermaid version 10.9.3. But working on mermaid 11.

Maybe adding a parameter to pdoc to provide a link to mermaid yourself is a good idea? Like overwriting the CDN link.

  • choose your own version (up and downgrade yourself)
  • use a self hosted version
    • if you don't want to use a CDN
    • if you don't have access to global internet

@mhils
Copy link
Member

mhils commented Dec 12, 2024

I've pushed a new release.

Maybe adding a parameter to pdoc to provide a link to mermaid yourself is a good idea? Like overwriting the CDN link.

This adds additional CLI complexity, which we want to avoid. If you need a custom Mermaid version, you can always put a mermaid.html.jinja2 in your custom template directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants