Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error check in xccdf_results2hdf mapper #4254

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add error check in xccdf_results2hdf mapper #4254

wants to merge 1 commit into from

Conversation

em-c-rod
Copy link
Contributor

@em-c-rod em-c-rod commented Mar 23, 2023 •
edited
Loading

fixes mitre/saf#1183

  • add check that the text field exists before calling .match on it
  • add logger
  • Test that logging displays as expected

add check that the text field exists before calling .match on it, als…
8a0ce02 
…o add logging. Logging does not display as expected

Signed-off-by: Emily Rodriguez <[email protected]>
@em-c-rod em-c-rod mentioned this pull request Mar 23, 2023
Open
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aaronlippold aaronlippold requested a review from Amndeep7 March 28, 2023 01:53
@aaronlippold aaronlippold added bug Something isn't working enhancement New feature or request labels Mar 28, 2023
@aaronlippold
Copy link
Member

#4255 also seems to update the CCI linking ... maybe worth a look

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2023

This pull request has a conflict. Could you fix it @em-c-rod?

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 6, 2024

This pull request has a conflict. Could you fix it @em-c-rod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Awaiting requested review from Amndeep7

At least 1 approving review is required to merge this pull request.

Assignees

@em-c-rod em-c-rod

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert xccdf_results2hdf: TypeError: Cannot read properties of undefined (reading 'match')
2 participants
@em-c-rod @aaronlippold