-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-release-pr #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR body is updated! diff
---
+++
@@ -1 +1,11 @@
-TBD
+## Changes
+
+- Create auto-release-pr action
+- Test auto-release-pr
+- Convert to Docker based action
+- Remove unused key
+- Set name
+- Run ls
+- Specify absolute path
+- Pass args for the number of PR
+- [temp] dummy body |
👍 |
PR body is updated! diff
---
+++
@@ -9,3 +9,11 @@
- Specify absolute path
- Pass args for the number of PR
- [temp] dummy body
+- Revert "[temp] dummy body"
+
+This reverts commit 75620bfce6722c9ca489c0ed8ab63ee6181526e4.
+- Fix to use passed value
+- README
+- Link to auto-release-pr
+- Make template configurable
+- [temp] dummy body |
andooown
force-pushed
the
work/auto-release-pr
branch
from
August 24, 2020 08:57
acc53bc
to
0d2054c
Compare
diff+++ @@ -1,4 +1,4 @@ -## Changes
-This reverts commit 75620bf.
+以上 |
This reverts commit 0d2054c.
enerick
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自動リリースPRのActionを共通で使えるように移植しました。
内部で利用していたものからの差分は
baseBranch
/headBranch
/releasePRNumber
のパラメーターを追加です。
GitHub Actionsのcomposite run steps actionではまだ
uses
をつかった既存のActionの利用ができないため、暫定的にDockerベースのActionとして構築しました。毎回
docker build
が走りますが、それを含めて1分以内で完了しているので一旦許容したいです。ActionsのIssue(https://github.com/actions/runner/issues/646)では
uses
の利用もロードマップに入っているようなので、実装されたら移行する予定です。