fix: not escaping double quotes #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add jest to test DrupalAttribute's `toString` method. For this, `DrupalAttribute` was moved into its own file so it can be imported in the test without adding it to the export of index.js.
kleinfreund
force-pushed
the
fix/not-escaping-double-quotes
branch
from
922b8ad to
88725a8
Compare
Fix not converting array of strings values. This was likely caused by naming the variable for attribute `value` and the one for the attribute value `key`. Change the variable names to be more accurate. Add a better JSDoc type annotation for `this.args` to make more obvious when errors in normalizing attribute values occur.
kleinfreund
force-pushed
the
fix/not-escaping-double-quotes
branch
from
88725a8 to
11cb299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: This PR is based on #11 and so it currently includes that PR's changes as PRs from forks can't target another fork PR's branch. Should #11 be merged, this PR will be rebased and those extra changes will vanish from this PR.)
Changes
Fix not escaping double quotes in attribute values using
".