[Improvement] Add an image pull secret to Jupyter deployment (#160)

mlrun · Feb 5, 2025 · 1fdc1c0 · 1fdc1c0
1 parent 45c1c45
commit 1fdc1c0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/charts/mlrun-ce/Chart.yaml b/charts/mlrun-ce/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v1
 name: mlrun-ce
-version: 0.7.1-rc10
+version: 0.7.1-rc11
 description: MLRun Open Source Stack
 home: https://iguazio.com
 icon: https://www.iguazio.com/wp-content/uploads/2019/10/Iguazio-Logo.png

diff --git a/charts/mlrun-ce/templates/jupyter-notebook/deployment.yaml b/charts/mlrun-ce/templates/jupyter-notebook/deployment.yaml
@@ -15,6 +15,10 @@ spec:
       labels:
         {{- include "mlrun-ce.jupyter.selectorLabels" . | nindent 8 }}
     spec:
+      {{- with .Values.jupyterNotebook.image.pullSecrets }}
+      imagePullSecrets:
+          {{- toYaml . | nindent 8 }}
+      {{- end }}
 {{- if  .Values.jupyterNotebook.serviceAccount.name }}
       serviceAccount: {{ .Values.jupyterNotebook.serviceAccount.name }}
 {{- end }}

diff --git a/charts/mlrun-ce/values.yaml b/charts/mlrun-ce/values.yaml
@@ -190,6 +190,7 @@ jupyterNotebook:
     repository: quay.io/mlrun/jupyter
     tag: 1.7.1
     pullPolicy: IfNotPresent
+    pullSecrets: []
   busybox:
     image: busybox
     tag: 1.35