Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlrun-ce] Jupyter data persistent #84

Merged
merged 8 commits into from
Nov 30, 2023
Merged

[mlrun-ce] Jupyter data persistent #84

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c756663
Update deployment.yaml
eliyahu77 Nov 7, 2023
cf16a4c
Update Chart.yaml
eliyahu77 Nov 7, 2023
bdb1872
Update values.yaml
eliyahu77 Nov 29, 2023
bdd8837
Update values.yaml
eliyahu77 Nov 29, 2023
e9c09de
Update deployment.yaml
eliyahu77 Nov 29, 2023
abe917a
Update values.yaml
eliyahu77 Nov 30, 2023
521387b
Update deployment.yaml
eliyahu77 Nov 30, 2023
c3a6469
Update values.yaml
eliyahu77 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/mlrun-ce/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
version: 0.6.3-rc4
version: 0.6.3-rc5
name: mlrun-ce
description: MLRUn Open Source Stack
home: https://iguazio.com
Expand Down
21 changes: 7 additions & 14 deletions charts/mlrun-ce/templates/jupyter-notebook/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ spec:
spec:
{{- if .Values.jupyterNotebook.awsInstall }}
serviceAccount: {{ .Values.jupyterNotebook.serviceAccount }}
{{- end }}
{{- end }}
securityContext:
runAsUser: 1000
runAsGroup: 100
fsGroup: 100
initContainers:
- name: init-chown-data
# jupyter default NB user: uid=1000(jovyan) gid=100(users) groups=100(users)
command: ["chown", "-R", "1000:100", "/home/jovyan/data"]
command: ["chown", "-R", "1000:100", "/home/jovyan/"]
image: busybox:1.35
imagePullPolicy: IfNotPresent
securityContext:
runAsUser: 0
volumeMounts:
- mountPath: /home/jovyan/data
- mountPath: /home/jovyan/
name: notebooks
containers:
- name: jupyter-notebook
Expand All @@ -52,8 +52,8 @@ spec:
value: {{ index .Values "mpi-operator" "crd" "version" }}
{{- if .Values.jupyterNotebook.persistence.enabled }}
- name: MLRUN_PVC_MOUNT
value: {{ printf "%s:/home/jovyan/data" (include "mlrun-ce.jupyter.fullname" .) }}
{{- end }}
value: {{ printf "%s:/home/jovyan/" (include "mlrun-ce.jupyter.fullname" .) }}
{{- end }}
- name: CHOWN_HOME
value: "yes"
- name: CHOWN_HOME_OPTS
Expand All @@ -72,19 +72,12 @@ spec:
{{ toYaml .Values.jupyterNotebook.envFrom | nindent 10 }}
{{- end }}
volumeMounts:
- mountPath: /home/jovyan/data
- mountPath: /home/jovyan/
name: notebooks
ports:
- containerPort: 8888
name: http
command: [ "start-notebook.sh" ]
args:
- --NotebookApp.allow_origin="*"
- --ip="0.0.0.0"
- --port=8888
- --NotebookApp.token=''
- --NotebookApp.password=''
- --NotebookApp.default_url="/lab"
command: ["/bin/bash", "/usr/local/bin/mlce-start.sh"]
{{- with .Values.jupyterNotebook.nodeSelector }}
nodeSelector: {{ toYaml . | nindent 8 }}
{{- end }}
Expand Down
8 changes: 5 additions & 3 deletions charts/mlrun-ce/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ mlrun:
api:
fullnameOverride: mlrun-api
image:
tag: 1.4.0
tag: 1.6.0-rc8
eliyahu77 marked this conversation as resolved.
Show resolved Hide resolved
service:
type: NodePort
nodePort: 30070
Expand Down Expand Up @@ -112,7 +112,7 @@ mlrun:
type: NodePort
nodePort: 30060
image:
tag: 1.4.0
tag: 1.6.0-rc8
db:
name: db
fullnameOverride: mlrun-db
Expand Down Expand Up @@ -148,6 +148,7 @@ mlrun:

jupyterNotebook:
awsInstall: false
authType: cred
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if not used

fullnameOverride: mlrun-jupyter
name: jupyter-notebook
enabled: true
Expand All @@ -171,7 +172,7 @@ jupyterNotebook:
# - chart-example.local
image:
repository: quay.io/mlrun/jupyter
tag: 1.4.0
tag: 1.6.0-rc8
pullPolicy: IfNotPresent

# use this to override mlrunUIURL, by default it will be auto-resolved to externalHostAddress and
Expand All @@ -191,6 +192,7 @@ jupyterNotebook:
envFrom:
- configMapRef:
name: jupyter-common-env
optional: true
persistence:
enabled: true
existingClaim:
Expand Down