Merge pull request #764 from aviaIguazio/development

[cli] add state_thresholds support
mlrun · Jan 1, 2024 · aa83330 · aa83330
2 parents c619c72 + 40386ec
commit aa83330
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/cli/helpers.py b/cli/helpers.py
@@ -167,6 +167,8 @@ def get_item_yaml_values(
         if values:
             if isinstance(values, list):
                 values_set = set(values)
+            elif isinstance(values, dict):
+                values_set = values
             else:
                 values_set.add(values)
         values_dict[key] = values_set

diff --git a/cli/item_to_function.py b/cli/item_to_function.py
@@ -55,17 +55,17 @@
     help="If -b/--bump_version is enabled, increase the minor version in the item.yaml file",
 )
 def item_to_function_cli(
-    item_path: str, output_path: Optional[str], code_output: bool, format_code: bool, bump_version: bool
+        item_path: str, output_path: Optional[str], code_output: bool, format_code: bool, bump_version: bool
 ):
     item_to_function(item_path, output_path, code_output, format_code, bump_version)
 
 
 def item_to_function(
-    item_path: str,
-    output_path: Optional[str] = None,
-    code_output: bool = False,
-    format_code: bool = True,
-    bump_version: bool = False,
+        item_path: str,
+        output_path: Optional[str] = None,
+        code_output: bool = False,
+        format_code: bool = True,
+        bump_version: bool = False,
 ):
     item_path = Path(item_path)
     if item_path.is_dir():
@@ -78,9 +78,9 @@ def item_to_function(
     # That means we need to search for items inside this direcotry
     else:
         for inner_dir in PathIterator(
-            root=item_path.parent,
-            rule=is_item_dir,
-            as_path=True,
+                root=item_path.parent,
+                rule=is_item_dir,
+                as_path=True,
         ):
             try:
                 _output_path = output_path or (inner_dir / "function.yaml")
@@ -119,11 +119,11 @@ def _get_item_yaml(item_path: Path) -> dict:
 
 
 def create_function_yaml(
-    item_path: Union[str, Path],
-    output_path: Optional[str] = None,
-    code_output: bool = False,
-    format_code: bool = True,
-    bump_version: bool = False,
+        item_path: Union[str, Path],
+        output_path: Optional[str] = None,
+        code_output: bool = False,
+        format_code: bool = True,
+        bump_version: bool = False,
 ):
     item_path = Path(item_path)
     if bump_version:
@@ -161,7 +161,8 @@ def create_function_yaml(
     # remove build info from object
     function_object.spec.build.code_origin = ''
     function_object.spec.build.origin_filename = ''
-    function_object.spec.state_thresholds=None
+    if 'state_thresholds' not in spec:
+        function_object.spec.state_thresholds = None
 
     custom_fields = spec.get("customFields", {})
     for key, value in custom_fields.items():