Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translate] updated notebook #759

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

ZeevRispler
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@guy1992l guy1992l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice Ze'ev! Few suggestions:

  • I would give a shoutout to Helsinki in the background section with a link to their huggingface page. This function auto-model selection is based on the great translation models offered by Helsinki. Check them out [here](link to their page).
  • The documentation has a redundant header - Explanation about function parameters.
  • The demo is great but I like demos to have numbered sections. So:
    • (1.) Import the function (import mlrun, set project and import function)
    • (2.) Usage
      • (2.1.) Auto model detectyion
      • (2.2.) Manual model selection
    • (3.) Review results - cover the returned artifacts the function has, perhaps show them if possible (in this function you can print out the dataframe and print the translated file maybe.

@aviaIguazio aviaIguazio merged commit d18acbf into mlrun:development Dec 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants