Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyannote_audio] Rename speech diarization to this new name #766

Merged
merged 17 commits into from
Jan 9, 2024
Merged

[pyannote_audio] Rename speech diarization to this new name #766

merged 17 commits into from
Jan 9, 2024

Conversation

guy1992l
Copy link
Member

@guy1992l guy1992l commented Jan 4, 2024 •
edited
Loading

Rename the function name from speech_diarization to pyannote_audio

yonishelach and others added 16 commits March 8, 2023 11:01
@yonishelach
[Build] Fix html links, Add <function>.html as source in documentation
356264f
@yonishelach
Update CI temporarily and update index
2202caf
@yonishelach
Merge pull request mlrun#615 from yonishelach/fix-links-html
b0f2b5d 
[Build] Fix html links, add <function>.html as source in documentation
@yonishelach
[XGB-Custom] Fix test artifact key name
8b17c8f
@yonishelach
Merge pull request mlrun#616 from yonishelach/fix-xgb-custom-test
f42f3e3 
[XGB-Custom] Fix test artifact key name
@yonishelach
[XGB-Serving][XGB-Test][XGB-Trainer] Fix tests - artifact key
a469dca
@yonishelach
Merge pull request mlrun#617 from yonishelach/fix-xgb-custom-test
80c7de2 
[XGB-Serving][XGB-Test][XGB-Trainer] Fix tests - artifact key
@yonishelach
[Build] Install python 3.9 when testing (mlrun#618)
3301415
@yonishelach
[Build] Update python version in CI (mlrun#620)
0cd1f15 
* [Build] Install python 3.9 when testing

* [Build] Update python version in CI

* .
@yonishelach
Revert "[Build] Update python version in CI (mlrun#620)" (mlrun#621)
33e7ab8 
This reverts commit 0cd1f15.
@yonishelach
Revert "[Build] Install python 3.9 when testing (mlrun#618)" (mlrun#619)
7a7473b 
This reverts commit 3301415.
@yonishelach
[Build] Build with python 3.9 (mlrun#622)
81437da 
* [Build] Build with python 3.9

* .
@guy1992l
Merge branch 'development' of https://github.com/mlrun/functions into…
c0a1bb8 
… development
@guy1992l
Merge branch 'development' of https://github.com/mlrun/functions into…
10cf170 
… development
@guy1992l
Merge branch 'development' of https://github.com/mlrun/functions into…
81b45ae 
… development
@guy1992l
rename
315a854
yonishelach
yonishelach requested changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@yonishelach yonishelach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
only two minor comments.

worth to mention:
The original function is already in marketplace/development and after merging, the CI is going to delete the original speech_diarization function, as expected.

pyannote_speech_diarization/item.yaml Outdated Show resolved Hide resolved
pyannote_speech_diarization/test_pyannote_speech_diarization.py Outdated Show resolved Hide resolved
@guy1992l guy1992l changed the title [pyannote_speech_diarization] Rename speech diarization to this new name [pyannote_audio] Rename speech diarization to this new name Jan 8, 2024
@yonishelach yonishelach merged commit 95b7dc1 into mlrun:development Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonishelach yonishelach yonishelach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guy1992l @yonishelach