Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text to audio generator] Add speech engine #838

Merged
merged 7 commits into from
Jan 2, 2025

Conversation

yonishelach
Copy link
Collaborator

@yonishelach yonishelach commented Dec 31, 2024

This PR brings the bark option back to the function

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yonishelach yonishelach changed the title [Text to audio generator] Fix base url env var [Text to audio generator] Add speech engine Jan 1, 2025
from typing import Dict, List, Optional, Tuple, Union

import numpy as np
import openai
import pandas as pd
import torch
import torchaudio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused import in L29 from pydub import AudioSegment

@@ -22,8 +22,9 @@ spec:
image: mlrun/mlrun
kind: job
requirements:
- openai
- bark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if I'm using openai, I don't need to install bark, and vice versa, correct? perhaps we should exclude both from reqs and the user will have to add his required package on his own.

@Eyal-Danieli Eyal-Danieli merged commit b3eb31a into mlrun:development Jan 2, 2025
3 checks passed
Eyal-Danieli pushed a commit to Eyal-Danieli/functions that referenced this pull request Jan 5, 2025
* [text to audio generator] Replaced bark with openai tts models

* [text to audio generator] Fix base url env var

* fix version

* Add speech engine

* after review
Eyal-Danieli added a commit that referenced this pull request Jan 5, 2025
* fix PyYAML loading (#837)

* [text to audio generator] Replaced bark with openai tts models (#836)

* [Text to audio generator] Add speech engine (#838)

* [text to audio generator] Replaced bark with openai tts models

* [text to audio generator] Fix base url env var

* fix version

* Add speech engine

* after review

* [auto-trainer] update test requirements (#839)

* [Build] Fix html links, Add <function>.html as source in documentation

* Update CI temporarily and update index

* [XGB-Custom] Fix test artifact key name

* [XGB-Serving][XGB-Test][XGB-Trainer] Fix tests - artifact key

* [Build] Install python 3.9 when testing (#618)

* [Build] Update python version in CI (#620)

* [Build] Install python 3.9 when testing

* [Build] Update python version in CI

* .

* Revert "[Build] Update python version in CI (#620)" (#621)

This reverts commit 0cd1f15.

* Revert "[Build] Install python 3.9 when testing (#618)" (#619)

This reverts commit 3301415.

* [Build] Build with python 3.9 (#622)

* [Build] Build with python 3.9

* .

* Update requirements.txt

---------

Co-authored-by: Yonatan Shelach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants