Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDL_CreateWindowFrom #1033

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

jonata
Copy link
Contributor

@jonata jonata commented Oct 8, 2024

Fixes #303

@ddennedy ddennedy added this to the v7.28.0 milestone Oct 8, 2024
@ddennedy
Copy link
Member

ddennedy commented Oct 8, 2024

@jliljebl Check this out and related discussion #1032 to see if you can not embed sdl2 in GTK+.

@ddennedy ddennedy merged commit 7acb1f1 into mltframework:master Oct 8, 2024
6 checks passed
@jliljebl
Copy link
Contributor

jliljebl commented Oct 9, 2024

And now it works. This 100% what I did last time, several times. Send monitor widget xid to SDL_CreateWindowFrom and launch player a bit later to make sure everything is initialized.

Thanks to @jonata for trying this once more, guess I gave up on this simplest approach too early.

@ddennedy ddennedy modified the milestones: v7.28.0, v7.30.0 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdl2 in window_id frame tkinter
3 participants