Fix various aspect ratio issues with qtblend filter/transition #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatherly
requested changes
Feb 5, 2025
There was a problem hiding this comment.
I don't have much opinion on the substance of the change. It seems a little strange that a filter would keep track of whether it has been applied already. But I don't have a better idea for how to handle that situation. Maybe there should be a generic way to indicate that the original image has already been scaled (like affine).
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| #include <framework/mlt.h> | |||
|
|
|||
| #define MLT_QTBLEND_MAX_DIMENSION (16000) | |||
There was a problem hiding this comment.
Why is this defined here if it is only used in filter_qtblend.cpp
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * filter_lightshow.cpp -- animate color to the audio | |||
| * filter_qtblend.cpp -- Qt composite filter | |||
| * Copyright (C) 2015 Meltytech, LLC | |||
There was a problem hiding this comment.
It would be good to update the copyright date in all of these files that are changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple issues when applying several qtblend filters on the same frame.
One issue is that the qtblend filter, like the affine filter/transition, sometimes query an image using the producer's original resolution, not in profile resolution in order to be able to display for example to zoom in a 4k clip with an HD profile, while keeping the 4K resolution.
However this caused issues because in several parts of the code, we calculate the preview scaling by comparing the size of the requested image with the size of the project profile.
Among the several fixes in this patch, we now check if another qtblend filter was applies and use a cached value for consumer scaling.