Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc: allocation resilient to aliased input/output #134

Merged
merged 16 commits into from
Nov 1, 2021
Merged

Conversation

mmcloughlin
Copy link
Owner

Updates #129

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #134 (99f4b4b) into master (2cfd897) will decrease coverage by 0.24%.
The diff coverage is 79.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   74.01%   73.76%   -0.25%     
==========================================
  Files          35       36       +1     
  Lines        2078     2169      +91     
==========================================
+ Hits         1538     1600      +62     
- Misses        474      494      +20     
- Partials       66       75       +9     
Flag Coverage Δ
unittests 73.76% <79.37%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
acc/eval/interp.go 58.57% <58.57%> (ø)
acc/pass/pass.go 89.33% <76.92%> (+2.23%) ⬆️
acc/pass/alloc.go 90.00% <96.87%> (+1.11%) ⬆️
internal/examples/fp25519/inv.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfd897...99f4b4b. Read the comment docs.

Extends the suite of allocation checks:

- every operand has a name
- names used are: input, output, temporaries
- input not written to
- input and output not live at same time
- live operands have unique names
- executing the program gives the right result
@mmcloughlin mmcloughlin changed the title acc: Allocator resilient to aliased input/output acc: allocation resilient to aliased input/output Nov 1, 2021
@mmcloughlin mmcloughlin marked this pull request as ready for review November 1, 2021 05:07
@mmcloughlin mmcloughlin merged commit 35fc856 into master Nov 1, 2021
@mmcloughlin mmcloughlin deleted the alias branch November 1, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants