acc: results test #136
Merged
acc: results test #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 74.00% 74.00%
=======================================
Files 36 36
Lines 2177 2177
=======================================
Hits 1611 1611
Misses 492 492
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
When run locally: Related: dead code elimination #133 |
This was referenced Nov 1, 2021
mmcloughlin
added a commit
that referenced
this pull request
Nov 2, 2021
The variable allocator currently raises an assertion error if it encounters a write to an operand without an allocation. Allocation is done like liveness analysis: the instructions are processed in reverse and variables are allocated as they are read, freed when they're written to. Therefore this assertion would trigger if the operand is never read after it's written. Therefore, this would only happen for a _redundant_ chain which computes a value it never needs. Clearly this isn't ideal, but it does seem to happen for some algorithms. It seems best that the allocator doesn't crash in these cases. This PR updates the allocation logic to handle this case. In practice if this happens the variable would be immediately allocated and freed. Updates #129 #133 #136
Updates #129
mmcloughlin
force-pushed
the
acc-results-test
branch
from
6a2650b to
e636632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #129