Store data as raw bytes - txo - key_image (RPS-8) #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2023
briancorbin
changed the title
briancorbin
force-pushed
the
store-data-as-raw-bytes/txo/key_image
branch
from
9a5b045 to
da5cba5
Compare
briancorbin
force-pushed
the
store-data-as-raw-bytes/txo/target_key
branch
from
ebe559b to
902c1d3
Compare
briancorbin
force-pushed
the
store-data-as-raw-bytes/txo/key_image
branch
from
da5cba5 to
45f45e8
Compare
briancorbin
changed the base branch from
store-data-as-raw-bytes/txo/target_key
to
main
briancorbin
requested review from
eranrund and
christian-oudard
as code owners
eranrund
reviewed
Dec 6, 2023
| @@ -3,6 +3,8 @@ | |||
| //! A subaddress assigned to a particular contact for the purpose of tracking | |||
| //! funds received from that contact. | |||
|
|
|||
| use std::convert::TryInto; | |||
|
|
|||
There was a problem hiding this comment.
Nit: no new line, all imports grouped together
| @@ -170,6 +170,9 @@ pub enum WalletDbError { | |||
|
|
|||
| /// MemoDecoding: {0} | |||
| MemoDecoding(MemoDecodingError), | |||
|
|
|||
| /// Ring Signature error: {0} | |||
| RingSignature(mc_transaction_core::ring_signature::Error), | |||
There was a problem hiding this comment.
Curious why this was needed?
holtzman
requested review from
holtzman,
jgreat,
joekottke,
nick-mobilecoin,
starkriedesel and
sugargoat
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some unnecessary use of protobuf encoding of raw bytes for fields in the txo object.
Future PR will include updates to the API, but that will be a breaking change