Optimize artifacts submodule strategy #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…libraries from CICD
…bilecoinofficial/libmobilecoin-ios-artifacts into optimize-artifacts-submodule-strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soundtrack of this PR: link to song that really fits the mood of this PR
Motivation
I want to simplify the artifacts submodule and its relation to libmobilecoin. The current setup could create feature-branches in CICD with long histories, and then upon merge to master, we're essentially keeping these branches by tracking the commit in libmobilecoin.
The new solution is to rebase whatever commit is being pointed to onto
origin/mainaccepting all new changes, and the squash-merging. This compresses all new changes from the CICD feature branch to one commit.In this PR