Make propagation final of lifted parameter 'c' in Spring #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, the discussion in MO-2748 didn't take us much further. It gives us a language to express initialization problems more clearly in Base Modelica, but doesn't provide a full specification of how full Modelica initialization should be turned into Base Modelica. |
HansOlsson
reviewed
May 24, 2024
christiankral
approved these changes
May 24, 2024
tobolar
reviewed
Jun 4, 2024
There was a problem hiding this comment.
The thing is that I Joe Engineer would never come to the idea c is final due to a clear initialization.
@MartinOtter could you review here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3707.
As there wasn't any arguments agains making the propagation of
cfinal in #3707, I suggest that we go with this solution.One could argue that there are more parameters whose propagation should be final, but I'm starting with this one which is sufficient to fix the issue.