Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for a Windows PowerShell platform #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamretter
Copy link
Contributor

@adamretter adamretter commented Apr 17, 2019

See #79

This adds support for generating scripts for Windows PowerShell.

<platform>windows-ps</platform>

NOTE: This is not yet fully tested and I suspect some quoting issues in the generated PowerShell scripts, but I am opening this PR to see if there is any interest in adding PowerShell support to AppAssembler before I do further work on this...

@adamretter adamretter force-pushed the platform-windows-powershell branch from 8fc4dc5 to 88a7aa1 Compare April 17, 2019 05:07
@khmarbaise khmarbaise added this to the Release 3.0.0 milestone May 1, 2019
@khmarbaise
Copy link
Member

Can we have a consistent commit message like:

Fixed #70 - Add Support for Windows Powershell 

@adamretter
Copy link
Contributor Author

@khmarbaise Well this PR is just a work in progress. I mostly wanted feedback from you and the team as to whether this was even desirable? I don't actually need it myself anymore...

@khmarbaise
Copy link
Member

I think this is an improvement so If you want continue and ping if you are ready I appreciate to merge this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants