#201 - Reduce log level for unknown dependencies to debug to reduce l… #300
Conversation
…reduce log spam when using a shared missing file
There was a problem hiding this comment.
The proposed solution eliminates the warnings also for users that want to see them and I cannot accept it like this. I propose to solve the issue by adding a parameter much like we did in AbstractDownloadLicensesMojo
I'd recommend to add your own ErrorRemedy-like enum that would initially contain just warn (default) and ignore so that you not need to implement the other options we have in AbstractDownloadLicensesMojo.
Do not forget to add an integration test.
|
I'm interested in this change, is anybody currently working on it? Happy to help otherwise |
…ugin into 201-reduce-log-level # Conflicts: # src/main/java/org/codehaus/mojo/license/api/DefaultThirdPartyTool.java
| /** | ||
| * What to do on defined files not found in project. The possible values are: | ||
| * <li> | ||
| * <ul>{@link UnkownFileRemedy#debug}: unkown files are logged debug</ul> |
There was a problem hiding this comment.
Typo throughout the change Unkown -> Unknown
| @@ -552,7 +554,7 @@ public SortedProperties loadUnsafeMapping( LicenseMap licenseMap, | |||
| MavenProject project = artifactCache.get( id ); | |||
| if ( project == null ) | |||
| { | |||
| LOG.warn( "dependency [{}] does not exist in project.", id ); | |||
| handleUnkownDependency(unkownFileRemedy, "dependency [" + id + "] does not exist in project." ); | |||
There was a problem hiding this comment.
Probably cleaner to hand id down to handleUnkownDependency instead of passing the log message around.
|
postbuild integration tests seem to run not 100% stable -,.- |
|
can someone tell me why some builds fail randomly? |
|
@ppalaga Could you see why this jdk7 build fails please? |
…og spam when using a shared missing file
#201