-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle lineSeparator conversion with tokens LF / CRLF #410
base: master
Are you sure you want to change the base?
Conversation
Should be done in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to AbstractFileHeaderMojo
868fae0
to
74afa19
Compare
Updated to correct file, but not sure if setter is correctly picked up. |
Please also update documentation for field in Java docs
It will be used for generating description like in: https://www.mojohaus.org/license-maven-plugin/update-file-header-mojo.html#lineSeparator |
You can duplicate |
Tried to implement tests, but it looks like line ending got replaced by system one when either I may have more time to dig that later, but if you have any clue where this could happen, feel free to give advice ! I suspect something around following lines :
|
*/ | ||
package org.codehaus.mojo.license; | ||
|
||
public class Lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even it is test file should follow java conventions, class should the same name as file.
Please also check other test files.
Please always build locally ... last change has issue reported by spotless. |
This PR is linked to my comment on the issue #106
We are now able to provide the lineSeparator information with :
I tried to do the smallest change possible to avoid breaking anything, I'm not sure that it fits the codebase as I've not spent much time looking into the project.