6.4.8 #1358
Closed
6.4.8 #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit 72293f3.
While preapring for app freeze, we reset _shutdownPending to NO. That deactivated the failsafe used to ignore idle states on disconnected accounts and triggered a second shutdown. (But since the app suspension was already triggered (the bg task was terminated), the double shutdown got delayed to next app foreground.) The second shutdown tried to flush the log, but the logging queue was already suspended, so the flushing blocked the main thread indefinitely leading to the iOS watchdog killing the app. This was not visible in any logfiles, because of the suspended logging queue, but our new udp logger force send made it visible.
This makes sure we get it even when killed by some watchdog while disconnecting/shutting down
Before this commit, monal checked that an entity is not a gateway by verifying that its identity's type is 'text' https://xmpp.org/registrar/disco-categories.html#conference But non-IRC gateways can have an identity type of 'text'. Now, it will be checking that the entity does not advertise a category of 'gateway', as that's more robust. https://xmpp.org/extensions/xep-0100.html#example-3 This should work with Biboumi and Slidge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.