Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete @types/react-select #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete @types/react-select #269

wants to merge 1 commit into from

Conversation

horaotoko
Copy link
Member

ref: #163

react-select 本体がts化されたようなので、こちらは削除します。

@horaotoko horaotoko requested a review from a team as a code owner December 23, 2022 06:58
@horaotoko horaotoko requested review from kimromi and removed request for a team December 23, 2022 06:58
@kimromi
Copy link
Contributor

kimromi commented Dec 23, 2022

https://github.com/JedWatson/react-select/releases/tag/react-select%405.0.0
型が入ったの react-select v5 からみたいなので先に上げる必要がありそうです・・・・

@horaotoko
Copy link
Member Author

horaotoko commented Dec 23, 2022 •
edited
Loading

typecheck直さないとダメだった（ですよね）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimromi kimromi Awaiting requested review from kimromi kimromi is a code owner automatically assigned from moneyforward/fukuoka-frontend

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horaotoko @kimromi