Stop initialising the IsUnexpected flag to false for new errors

monzo · Aug 30, 2024 · 45a87db · 45a87db
1 parent 073654f
commit 45a87db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/errors_test.go b/errors_test.go
@@ -575,7 +575,7 @@ func TestSetIsRetryable(t *testing.T) {
 
 func TestSetIsUnexpected(t *testing.T) {
 	err := New("code", "message", nil)
-	assert.False(t, *err.IsUnexpected)
+	assert.Nil(t, err.IsUnexpected)
 
 	err.SetIsUnexpected(true)
 	assert.True(t, *err.IsUnexpected)

diff --git a/factory.go b/factory.go
@@ -117,10 +117,9 @@ func RateLimited(code, message string, params map[string]string) *Error {
 // Builds a stack based on the current call stack
 func errorFactory(code string, message string, params map[string]string) *Error {
 	err := &Error{
-		Code:         ErrUnknown,
-		Message:      message,
-		Params:       map[string]string{},
-		IsUnexpected: &notUnexpected,
+		Code:    ErrUnknown,
+		Message: message,
+		Params:  map[string]string{},
 	}
 	if len(code) > 0 {
 		err.Code = code