Add support for the 3DS #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoeyjodon
commented
Jan 4, 2024
zoeyjodon
commented
Jan 4, 2024
cgutman
reviewed
Jan 11, 2024
src/PlatformSockets.c
Outdated
| #ifdef __3DS__ | ||
| // binding to wildcard port is broken on the 3DS, so we need to define a port manually | ||
| struct sockaddr_in *n3ds_addr = &bindAddr; | ||
| n3ds_addr->sin_port = n3ds_udp_port++; |
There was a problem hiding this comment.
sin_port is expected to be in network byte order, so you should use htons() here.
cgutman
reviewed
Jan 11, 2024
cgutman
reviewed
Jan 11, 2024
cgutman
approved these changes
Jan 15, 2024
Prevent wildcard port binding on the 3DS Add 3DS threading logic Add 3DS socket logic Bump the connection timeout to 60s for the 3DS
|
Changes have been squashed! |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for 3DS-specific functionality. So far, I have been able to connect to both NVIDIA gamestream and Sunshine, but the connection is unstable and slow. I'm currently looking into optimizations, but the main functionality ought to be worth upstreaming in the meantime.
Issue
Resolves #33
Changelog