Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need to add in cash out codes for currency transaction activity … #87

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

mimy2001
Copy link

@mimy2001 mimy2001 commented Jan 4, 2024

Cash out codes are missing for currency transaction activity detail type

Screenshot 2024-01-04 at 5 08 49 PM

@mimy2001 mimy2001 requested a review from adamdecaf as a code owner January 4, 2024 22:18
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (adb21d0) 73.79% compared to head (c013fe1) 73.74%.

❗ Current head c013fe1 differs from pull request most recent head 006873a. Consider uploading reports for the commit 006873a to get more accurate results

Files Patch % Lines
pkg/currency_transaction/primitive.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   73.79%   73.74%   -0.05%     
==========================================
  Files          17       17              
  Lines        1698     1699       +1     
==========================================
  Hits         1253     1253              
- Misses        386      387       +1     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mimy2001
Copy link
Author

mimy2001 commented Jan 4, 2024

@adamdecaf Hey Adam, i don't have any options to merge this, is that new? I can't remember last time if I got an approval I can just push the code straight in or is it due to the code coverage bot above?

@adamdecaf adamdecaf merged commit dc269a6 into moov-io:master Jan 8, 2024
5 checks passed
@adamdecaf
Copy link
Member

Did we give you commit access to the repo? Usually a Moov employee reviews the code and merges when it looks good.

@mimy2001
Copy link
Author

ah ok :) i probably just remembered wrong, it's been a while since I've pushed a new fix. But I just put up another PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants